Skip to content

new icon: duckdb (original, plain) #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2025
Merged

new icon: duckdb (original, plain) #2378

merged 3 commits into from
Mar 8, 2025

Conversation

szarnyasg
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://duckdb.org/faq#where-do-i-find-the-duckdb-logo

canaleal
canaleal requested changes Mar 2, 2025
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good work. Just need to do the following.

  • Scale the SVGs so they are 128x128.
  • Optimize the SVGs using SVGOMG.
  • And update the fill color of the plain SVG.

Here is a tutorial on how to scale the svgs. And here is another on how to optimize the svgs using inkscape.

@szarnyasg
Copy link
Contributor Author

Hi @canaleal, thanks for the feedback. I updated the icons as requested.

@szarnyasg szarnyasg requested a review from canaleal March 6, 2025 09:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit dc21df4 into devicons:develop Mar 8, 2025
5 checks passed
@szarnyasg szarnyasg deleted the duckdb branch March 12, 2025 23:07
@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Jun 24, 2025
@canaleal canaleal mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal approved these changes

Assignees
No one assigned
Labels
feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szarnyasg @canaleal