-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: nats (original, plain) #2343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great work. Just a few comments about the scaling and color of the plain svg.
…l to primary color
@canaleal Thanks for the review! Just pushed an update with the SVGs updated to reach the edge of the fillbox. Note: the icon is not square, it is a rectangle whose longest dimension is the height. The Y dimension reached the edge of the fillbox, but the X dimension does not. Also updated the plain icon color to match the primary color in |
The icons are perfect. For the sizing, we just want to make sure that at least one of the sides (top-bottom or right-left) reach the edges of the viewbox. |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
It looks right to me. nano -> nats -> neo4j |
Its all good, there are other icons that are not sorted correctly. This sorted error is more of a warning. |
Thanks @canaleal. Do you know when the 2.17.0 release will be cut? |
Unfortunately the team is quite busy at the moment due to work, school, etc, so it may take some time. |
Thanks @canaleal! I’m happy to help too. I’m in the Discord server as well. |
Awesome sounds good. Thanks so much, and great job on the MR once again! |
Double check these details before you open a PR
develop
branch.devicon.json
file at the correct alphabetic position as seen hereThis PR closes #1996
Link to prove your SVG is correct and up-to-date.