Skip to content

new icon: love2d (original, plain, line) #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 10, 2025
Merged

new icon: love2d (original, plain, line) #2338

merged 5 commits into from
Mar 10, 2025

Conversation

WesleyMatthee
Copy link
Contributor

@WesleyMatthee WesleyMatthee commented Jan 23, 2025 •
edited by canaleal
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

Link to prove your SVG is correct and up-to-date.

@WesleyMatthee WesleyMatthee changed the base branch from master to develop January 23, 2025 16:47
@canaleal
Copy link
Member

Hi @WesleyMatthee, could you please update the MR to align with the guidelines in the wiki.

@WesleyMatthee
Updated Json file, fixed naming of icons and added love-plain.svg, l…
b812cef 
…ove-line.svg, removed padding on love-original
@canaleal canaleal changed the title new icon: love2d (application-x-love-game.svg, love.svg) new icon: love2d (original, plain, line) Mar 10, 2025
@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Mar 10, 2025
canaleal
canaleal approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed up some minor issues but all is good.

Also no artifacts in icomoon.

image

@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 864ed50 into devicons:develop Mar 10, 2025
5 checks passed
@canaleal canaleal mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal approved these changes

Assignees
No one assigned
Labels
feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WesleyMatthee @canaleal