Skip to content

new icon: cobol (original) #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2025
Merged

new icon: cobol (original) #2335

merged 3 commits into from
Jan 27, 2025

Conversation

gewaleelek
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #2081

Link to prove your SVG is correct and up-to-date.

The language doesn't really have a "logo" - official sources always just use the plain text "COBOL" like in here or here. I've made the icon with the official IBM Plex Sans font from here, and it should be the most recognizable representative of this language.

weh
weh approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
(just added a empty line)

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team January 21, 2025 15:21
@weh weh added the feature:icon PR when a new icon is ready to be added to the collection label Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit be83ac7 into devicons:develop Jan 27, 2025
5 checks passed
@gewaleelek gewaleelek deleted the cobol branch February 16, 2025 15:13
@gewaleelek gewaleelek restored the cobol branch February 16, 2025 15:17
@gewaleelek gewaleelek deleted the cobol branch February 16, 2025 15:18
@canaleal canaleal mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weh weh weh approved these changes

@canaleal canaleal canaleal approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gewaleelek @weh @canaleal