Newicons (c3, embeddedc, labview) #136
Conversation
|
Will do! |
|
@Berkmann18 - this is definitely a great list and we can use this as a reference point moving forward but I'd like to keep PRs and issues restricted to a single icon at a time. Trying to manage a list of over 100 icons can be a little challenging and will inevitably become out of sync. With isolated issues and PRs, we can keep things tidy and improve changelogs. Thanks so much! |
|
@iamclaytonray Indeed, it would need a bit of cleaning and updates so that it can reflect all the suggestions in one place (which will help to avoid people making duplicate issues or duplicated comments). |
|
Let's do an RFC and get this figured out! (I do agree having a central place of knowing what icons exist, which ones don't, etc is a good thing and like you said, will reduce dupes!) |
|
Should just add the icons in the PRs and leave the devicon.css alone? |
There was a problem hiding this comment.
Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:
- Create a separated pull request for each icon (no matter how many variations)
Also you do no need to modify devicon.css and regenerate the fonts. We will do that after adding the icons because when multiple people doing pull requests the same time we will overwrite with the fonts.
|
I will close this pull request and review your new requests! :) Thanks in advance for your contribution @mjlabe |
Added asm, c3, embeddedc, and labview, but I broke the wordmark classes for the icons that don't actually have wordmark icons (like c-plain-wordmark). Could someone please fix that before merging? Why does that exist anyway?