Skip to content

Add various new platforms and languages (elixir, phoenix, arduino, minix, raspberry pi) #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add various new platforms and languages (elixir, phoenix, arduino, minix, raspberry pi) #102

wants to merge 2 commits into from

Conversation

Kartstig
Copy link
Contributor

iamclaytonray
iamclaytonray suggested changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@iamclaytonray iamclaytonray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Can you please make separate pull requests for each icon? This will help keep things consistent and prevent PRs becoming too "muddy". Thanks so much for contributing!

@amacado amacado added the feature:icon PR when a new icon is ready to be added to the collection label Jun 8, 2020
@amacado amacado changed the title Add various new platforms and languages Add various new platforms and languages (elixir, phoenix, arduino, minix, raspberry pi) Jun 8, 2020
@amacado
Copy link
Member

amacado commented Jun 8, 2020

possible duplicate of #75 (phoenix) and #108 (arduino, pi)

@Berkmann18
Copy link
Contributor

@amacado #108 was posted after this one, but yeah it indeed seems to be a duplicate of #75.

@amacado
Copy link
Member

amacado commented Jun 8, 2020

@Berkmann18 you're right. Anyway, I'm thinking about to propose a "one pull/issue" per icon rule as @iamclaytonray mentioned this will hopefully result in a cleaner state and structure. I'm working on a concept (CONTRIBUTE.md)..

This was referenced Jun 8, 2020
Closed
Closed
Closed
Closed
@Kartstig
Copy link
Contributor Author

Kartstig commented Jun 8, 2020

Closing in favor of #216 #217 #218 #221

@Kartstig Kartstig closed this Jun 8, 2020
@Kartstig Kartstig deleted the add-icons branch June 8, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@iamclaytonray iamclaytonray iamclaytonray requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon Request - Phoenix Framework Icon Request - Elixir Elixir & Phoenix Icons?
4 participants
@Kartstig @amacado @Berkmann18 @iamclaytonray