Skip to content

Conversation

MichielPater
Copy link
Contributor

No description provided.

@MichielPater MichielPater changed the base branch from master to develop July 7, 2021 19:49
@tupaschoal
Copy link
Contributor

Note that this likely closes #345

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/unity/unity-original-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/unity/unity-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

@Thomas-Boi Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection labels Jul 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVGs and icons look great! Thank you for your work 😄. I hope you don't mind me changing the color in original version to match the wordmark version.

@Thomas-Boi Thomas-Boi merged commit 697abe4 into devicons:develop Jul 9, 2021
@amacado amacado mentioned this pull request Aug 14, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* new icon: unity (original, original-wordmark)

* Added viewbox for unity

* Update devicon.json

* Update color in icons/unity/unity-original.svg

Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants