-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: centos (original, original-wordmark) #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @MichielPater and thank you for the contribution. When I took a look at the icons I noticed that the original-wordmark
doesn't look right:
The original
looks better, but maybe you could reduce the "blank space" around it a little so it's not taking up so much empty space:
This comment has been minimized.
This comment has been minimized.
Hey @MichielPater, Please hold off fixing the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: David Leal <halfpacho@gmail.com>
…into add-centos
Co-authored-by: David Leal <halfpacho@gmail.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, this is the bug that the Peek Icons bot reported 😅 it was kind of hidden.
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @MichielPater; LGTM! Thank you for your contributions and time in adding new icons to our repository! 😄🎉
Hi @MichielPater, I'm sorry for the late response 😅. I've been distracted by a few other tasks and life in general. Unfortunately, the icon not clear enough that it's Perhaps we can make the outlines of the arrows transparent like the center? I think this will show the arrows and make it clearer that this is Let us know if you are up to this 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These suggestions optimize the SVGs. 🙂
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Amazing work, @MichielPater! Thank you for your contributions! 😄👍🎉
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
Wow @MichielPater It looks great now! Thank you very much for your effort 😄 Just so you know, we are temporarily pausing accepting icons PR. We are upgrading our peek-bot and we want to ensure this PR matches our new standards. The upgrade will be done by the next build release, which should be done either this or next week. Thank you for your patient and commitment! |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like: You can click on the pictures and zoom on them if needed. The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! I still can't get over how good centos looks now. Great job @MichielPater
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on all your contributions, @MichielPater! Thanks! 😄👍🎉
* new icon: centos (original, original-wordmark) * Updated scale for centos-original-wordmark.svg * Updated scale for centos-original.svg * Update centos-original-wordmark.svg * Update centos-original.svg * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * devicon.jsson: Fixed indentation * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Apply suggestions from code review * centos: added plain and plain-wordmark * Update icons/centos/centos-plain-wordmark.svg Co-authored-by: David Leal <halfpacho@gmail.com> * Update icons/centos/centos-plain.svg Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
No description provided.