Skip to content

Conversation

MichielPater
Copy link
Contributor

No description provided.

amacado
amacado previously requested changes Jul 7, 2021
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MichielPater and thank you for the contribution. When I took a look at the icons I noticed that the original-wordmark doesn't look right:
image

The original looks better, but maybe you could reduce the "blank space" around it a little so it's not taking up so much empty space:
image

@amacado amacado added the feature:icon PR when a new icon is ready to be added to the collection label Jul 7, 2021
@github-actions

This comment has been minimized.

@Thomas-Boi
Copy link
Member

Hey @MichielPater,

Please hold off fixing the fill issue reported by the bot. I'm trying to find a way to fix this issue permanently using our SVG-optimizer bot.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Panquesito7 Panquesito7 added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jul 22, 2021
@github-actions

This comment has been minimized.

Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7 Panquesito7 added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 26, 2021
@github-actions

This comment has been minimized.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, this is the bug that the Peek Icons bot reported 😅 it was kind of hidden.

@Panquesito7 Panquesito7 added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 26, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Panquesito7
Panquesito7 previously approved these changes Jul 26, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @MichielPater; LGTM! Thank you for your contributions and time in adding new icons to our repository! 😄🎉

@Panquesito7 Panquesito7 requested a review from Thomas-Boi July 26, 2021 22:45
@Thomas-Boi
Copy link
Member

Hi @MichielPater,

I'm sorry for the late response 😅. I've been distracted by a few other tasks and life in general.

Unfortunately, the icon not clear enough that it's centos since it now looks like a black geometric figure, which can be any other brands.

Perhaps we can make the outlines of the arrows transparent like the center? I think this will show the arrows and make it clearer that this is centos. If you can take the original version and make those outlines transparent, I think that'd be best.
image

Let us know if you are up to this 😄

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These suggestions optimize the SVGs. 🙂

MichielPater and others added 2 commits August 9, 2021 22:08
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Amazing work, @MichielPater! Thank you for your contributions! 😄👍🎉

@Thomas-Boi Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

Wow @MichielPater

It looks great now! Thank you very much for your effort 😄

Just so you know, we are temporarily pausing accepting icons PR. We are upgrading our peek-bot and we want to ensure this PR matches our new standards. The upgrade will be done by the next build release, which should be done either this or next week.

Thank you for your patient and commitment!

@Thomas-Boi Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 16, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like:
Imgur Images Imgur Images

You can click on the pictures and zoom on them if needed.

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! I still can't get over how good centos looks now. Great job @MichielPater

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on all your contributions, @MichielPater! Thanks! 😄👍🎉

@Thomas-Boi Thomas-Boi merged commit 4ec8c64 into devicons:develop Aug 16, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* new icon: centos (original, original-wordmark)

* Updated scale for centos-original-wordmark.svg

* Updated scale for centos-original.svg

* Update centos-original-wordmark.svg

* Update centos-original.svg

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

* devicon.jsson: Fixed indentation

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

* Apply suggestions from code review

* centos: added plain and plain-wordmark

* Update icons/centos/centos-plain-wordmark.svg

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update icons/centos/centos-plain.svg

Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants