Skip to content

Conversation

tupaschoal
Copy link
Contributor

Original
jetbrains-original
Plain
jetbrains-plain

I removed the eps, as it's not applicable anymore. I also removed the aliases, as the new icon doesn't look like a line.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if removing the .eps file is a good idea. @Thomas-Boi, thoughts?

@Panquesito7 Panquesito7 linked an issue Jul 2, 2021 that may be closed by this pull request
@Thomas-Boi
Copy link
Member

Hey @Panquesito7,

Since he's updating Jetbrains, he's removing the old .eps file. I think this is fine since it doesn't make sense to have an old .eps file while the icons are different

@Thomas-Boi Thomas-Boi changed the title Part of #128: Update JetBrains icons new icon: jetbrains (original, plain) Jul 4, 2021
@Thomas-Boi Thomas-Boi changed the title new icon: jetbrains (original, plain) Part of #128: Update JetBrains icons Jul 4, 2021
@Thomas-Boi Thomas-Boi changed the title Part of #128: Update JetBrains icons new icon: jetbrains (plain, original) Jul 4, 2021
@Thomas-Boi Thomas-Boi added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jul 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

Another great icon @tupaschoal ! Thank you for your work 😄

@Thomas-Boi Thomas-Boi dismissed Panquesito7’s stale review July 4, 2021 22:44

Outdated and has been applied

@Thomas-Boi Thomas-Boi merged commit eb1cdbc into devicons:develop Jul 4, 2021
@tupaschoal tupaschoal deleted the update-jetbrains branch July 5, 2021 00:38
@tupaschoal
Copy link
Contributor Author

I'm enjoying doing it :D

@amacado amacado mentioned this pull request Aug 14, 2021
@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Nov 5, 2023
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* Part of devicons#128: Update JetBrains icons

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Tag jetbrains with ide

Co-authored-by: David Leal <halfpacho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger enhancement feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JetBrains icons out of date
4 participants