Skip to content

new icon: denojs (original, original-wordmark, plain, plain-wordmark) #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

new icon: denojs (original, original-wordmark, plain, plain-wordmark) #709

wants to merge 16 commits into from

Conversation

informeai
Copy link
Contributor

added deno icon and resolve problem in issue #260

dependabot bot and others added 7 commits May 11, 2021 02:39
@dependabot
Bump hosted-git-info from 2.8.8 to 2.8.9
3436ea2 
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <support@github.com>
@Thomas-Boi
Merge pull request devicons#603 from devicons/dependabot/npm_and_yarn…
563d9cf 
…/hosted-git-info-2.8.9

Bump hosted-git-info from 2.8.8 to 2.8.9
@dependabot
Bump lodash from 4.17.20 to 4.17.21
c259984 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>
@Thomas-Boi
Merge pull request devicons#604 from devicons/dependabot/npm_and_yarn…
7a4ca8a 
…/lodash-4.17.21

Bump lodash from 4.17.20 to 4.17.21
@Thomas-Boi
Merge pull request devicons#682 from devicons/develop
9f4f5cd 
Release v2.12.0
Resolves issue devicons#260
3dfff02
@amacado
Merge branch 'develop' into master
bb05165
@amacado amacado added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jul 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2021

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Couldn't find an icon matching the name in the PR title.

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@amacado
Copy link
Member

amacado commented Jul 1, 2021

Hello @informeai! Thanks for picking up denojs.
I have to tell you, that this sadly does not fulfill our requirements.

  1. Instead of a vector graphic you have created a svg containing a base64 encoded image/png
  2. You added plain and plain-wordmark in the devicon.json, but you provided those icons not in your pull request
"font": [
   "plain",
   "plain-wordmark"
]

Maybe you can have a look at our CONTRIBUTING.md and try reworking denojs icon?

@amacado amacado self-requested a review July 1, 2021 22:11
@amacado amacado added the feature:icon PR when a new icon is ready to be added to the collection label Jul 1, 2021
@Panquesito7 Panquesito7 removed the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jul 1, 2021
Panquesito7
Panquesito7 requested changes Jul 2, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still working on making the original-wordmark version pure SVG.

Panquesito7
Panquesito7 reviewed Jul 2, 2021
View reviewed changes
@Thomas-Boi Thomas-Boi added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jul 3, 2021
@Thomas-Boi Thomas-Boi changed the title new icon: denojs(original,original-wordmark) new icon: denojs (original,original-wordmark) Jul 3, 2021
@Thomas-Boi Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2021

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Expecting ',' delimiter: line 938 column 9 (char 19856)

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2021

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Expecting ',' delimiter: line 938 column 9 (char 19856)

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@informeai informeai changed the title new icon: denojs (original,original-wordmark) new icon: denojs (original, original-wordmark, plain, plain-wordmark) Jul 3, 2021
@informeai
Copy link
Contributor Author

deno svg correction and devicon.json update

@informeai informeai closed this Jul 3, 2021
Panquesito7 added a commit that referenced this pull request Jul 4, 2021
@informeai @dependabot
@Thomas-Boi @amacado @Panquesito7
new icon: denojs (original, original-wordmark) (#713)
b13b02d 
* Bump hosted-git-info from 2.8.8 to 2.8.9

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <support@github.com>

* Bump lodash from 4.17.20 to 4.17.21

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>

* Resolves issue #260

* Make the `original` icon version pure SVG

Taken from [Wikipedia](https://es.wikipedia.org/wiki/Archivo:Deno.svg).

* Make the `original-wordmark` icon pure SVG

* Apply suggestions from code review

Co-authored-by: David Leal <halfpacho@gmail.com>

* svg concert for denojs
resolves #709

* update devicon.json and resolves #260

* update devicon.json and resolve #260

* delete files repeats

* Delete denojs-plain-wordmark.svg

* Delete denojs-plain.svg

* Update denojs-original-wordmark.svg

* Update denojs-original.svg

* Update denojs-original.svg

* Update denojs-original-wordmark.svg

* Update devicon.json

* Update denojs-original.svg

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Co-authored-by: Wellington Gadelha <wellingtongadelha@Informeai.local>
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@informeai @dependabot
@Thomas-Boi @amacado @Panquesito7
new icon: denojs (original, original-wordmark) (devicons#713)
b0fe469 
* Bump hosted-git-info from 2.8.8 to 2.8.9

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <support@github.com>

* Bump lodash from 4.17.20 to 4.17.21

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>

* Resolves issue devicons#260

* Make the `original` icon version pure SVG

Taken from [Wikipedia](https://es.wikipedia.org/wiki/Archivo:Deno.svg).

* Make the `original-wordmark` icon pure SVG

* Apply suggestions from code review

Co-authored-by: David Leal <halfpacho@gmail.com>

* svg concert for denojs
resolves devicons#709

* update devicon.json and resolves devicons#260

* update devicon.json and resolve devicons#260

* delete files repeats

* Delete denojs-plain-wordmark.svg

* Delete denojs-plain.svg

* Update denojs-original-wordmark.svg

* Update denojs-original.svg

* Update denojs-original.svg

* Update denojs-original-wordmark.svg

* Update devicon.json

* Update denojs-original.svg

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Co-authored-by: Wellington Gadelha <wellingtongadelha@Informeai.local>
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 requested changes

@amacado amacado Awaiting requested review from amacado

Assignees
No one assigned
Labels
bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@informeai @amacado @Panquesito7 @Thomas-Boi