Build bot now check both the PRs and the devicon.json for icons to be build
#686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amacado
reviewed
Jun 18, 2021
|
Also, for some reason the |
amacado
approved these changes
Jun 20, 2021
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
Build bot now check both the PRs and the `devicon.json` for icons to be build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
devicon.jsonto theicomoon.json(old feature) to find icons to be build.stale.ymlhas been moved to the draft folder since we do not need it for now. We can reuse it later if we wish to though.Test:
I ran the build bot after the upgrade. Since we just have a new release, the PRs would yield nothing. However, comparing the
devicon.jsonandicomoon.jsondid yieldarduino.Fixes #684