Skip to content

Conversation

Thomas-Boi
Copy link
Member

Taken from #116. Work was done by @pmz64.

@Thomas-Boi Thomas-Boi added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label May 27, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem (sorry!).

Please double check and fix the possible issues below:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail (sorry!) or there are other erros, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels May 27, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem (sorry!).

Please double check and fix the possible issues below:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail (sorry!) or there are other erros, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels May 27, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem (sorry!).

Please double check and fix the possible issues below:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail (sorry!) or there are other erros, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels May 27, 2021
@amacado amacado added the feature:icon PR when a new icon is ready to be added to the collection label May 27, 2021
@Thomas-Boi Thomas-Boi requested a review from amacado May 27, 2021 19:14
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top right):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if Microsoft Excel should be part of this iconset. I unterstand that you can script within excel (macros/vb) but I'm not sure if it fit's within our guidelines. I would like to open a discussion about it.

@amacado amacado added the discussion Community discussions about changes/features/.. label May 27, 2021
@Thomas-Boi
Copy link
Member Author

I was a bit iffy on this too but apparently, many businesses like small accounting or insurance firms still use Excel as a database of sort. Furthermore, I've heard learning VBA is a huge advantage => VBA runs in Excel so it makes Excel like an "editor" for VBA.

@Panquesito7
Copy link
Member

Well, many developers use Excel, but its purpose is not mainly for developers. I'm not really sure what to do, but I guess we can remove it. There's no harm if we keep it or remove it. 🙂

Panquesito7
Panquesito7 previously approved these changes May 27, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon itself looks good, though. 👍

@Thomas-Boi
Copy link
Member Author

Thomas-Boi commented May 27, 2021

Let's open this up in Discussion and see what people think. I'm still not sure how to deal with this specific icon.

Co-authored-by: David Leal <halfpacho@gmail.com>
@cseelus
Copy link
Contributor

cseelus commented May 29, 2021

Well, Excel is the reason many mere mortals have done reactive programming, probably without even realizing it: https://branch-blog.qlik.com/what-is-reactive-programming-a1e82cf28575

@Thomas-Boi
Copy link
Member Author

Since there's not a lot of strong support for Excel, I think we can close this PR for now. If we ever need to get the icon (see someone make a good case for it), we can reopen this.

@Thomas-Boi Thomas-Boi closed this Jun 13, 2021
@Thomas-Boi Thomas-Boi deleted the TB/excel branch June 13, 2021 21:03
@Thomas-Boi
Copy link
Member Author

I'll keep a local copy of the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger discussion Community discussions about changes/features/.. feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants