Skip to content

Conversation

Panquesito7
Copy link
Member

Things added/changed:

  • Update package.json for the new release.

@Panquesito7 Panquesito7 added the devops Devops/automation related enhancements label Apr 8, 2021
@Panquesito7 Panquesito7 requested a review from Thomas-Boi April 8, 2021 17:48
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we done with all new Icons?

@Panquesito7
Copy link
Member Author

Are we done with all new Icons?

Yeah, I think so. I was planning to add more, but I think it should be done for another release. 🙂

@Thomas-Boi
Copy link
Member

@amacado I believe one of our contributor (maltejur) was asking for another release because they need some of the new icons in the npm package.

Also @amacado, is there anything else that we need to do for a new release. @Panquesito7 and I were talking about this and so far, the steps are:

  • Update package.json
  • Run the npm release workflow
  • Open a PR into master

Is there anything that we're missing?

@Thomas-Boi
Copy link
Member

Also, @Panquesito7 did you use the command to change the version? The one in the PR on the NPM release

@Panquesito7
Copy link
Member Author

use the command to change the version

No, I changed the version in package.json manually.

@amacado
Copy link
Member

amacado commented Apr 8, 2021

I will write a "how to publish" in a few hours.

@Thomas-Boi
Copy link
Member

I will write a "how to publish" in a few hours.

Sweet, thank you 😄. You can also message us on the Discord server as well. I've been planning to make a Google Docs or at least a contributor-readme for a while now. It'll be great if we can aggregate them in one place.

@Thomas-Boi
Copy link
Member

use the command to change the version

No, I changed the version in package.json manually.

I think we should use the command. @amacado said in his PR that we also need to update the package-lock.json. I think we should do so just to be safe.

@Panquesito7
Copy link
Member Author

What is the command? I'm not so sure what command you're talking about. 😅

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve it once the how to is ready. Be prepared ;-)

@Thomas-Boi
Copy link
Member

@Panquesito7 I was referring to the one in this PR

@Thomas-Boi
Copy link
Member

I'll close this branch for now. I think we can let @amacado handle things for this release. Perhaps we can work together somehow? There's a lot of things needed to be done to create a new release.

@Thomas-Boi Thomas-Boi closed this Apr 9, 2021
@amacado amacado deleted the panquesito7/update/package_json branch April 10, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Devops/automation related enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants