Skip to content

Conversation

amacado
Copy link
Member

@amacado amacado commented Feb 23, 2021

I tried to work with https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idenvironment in the npm_publish workflow. This pull request will hopefully fix the workflow for the next release ;-) This time I will publish to npm by hand.

@amacado amacado added enhancement devops Devops/automation related enhancements labels Feb 23, 2021
@amacado amacado requested a review from Thomas-Boi February 23, 2021 18:20
@github-actions
Copy link
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

0

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

@Thomas-Boi
Copy link
Member

Hmm, the bot is not working as expected. I'll have to take another look into this.

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

@amacado amacado merged commit 570f6ac into develop Feb 23, 2021
@amacado amacado deleted the amacado/feature/npm-publish-workflow branch February 23, 2021 18:45
@amacado amacado mentioned this pull request Feb 23, 2021
1 task
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Devops/automation related enhancements enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants