Skip to content

Conversation

Panquesito7
Copy link
Member

I added an icon for AArch64 (also see https://github.com/TheAlgorithms/AArch64_Assembly).
I didn't find out any official logos, so I picked up the logo and converted it to .svg format from this website and slightly modified it. Resized using the resize-image tool. 🙂

This is how they look:

AArch64 original icon AArch64 plain icon

They look kinda stretched, but not sure what to do.
If I missed up anything, please let me know. Thank you.

@github-actions

This comment has been minimized.

@maltejur maltejur mentioned this pull request Feb 21, 2021
4 tasks
@amacado amacado requested a review from Thomas-Boi February 21, 2021 23:52
@github-actions
Copy link
Contributor

Hi!
I'm Devicons' SVG-Checker Bot and I just checked all the SVGs in this branch.

Everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@amacado
Copy link
Member

amacado commented Feb 21, 2021

That's a tough decision. I'm not sure if AArch64 fulfills our guidelines about which type of icons should be added to this project (see #353). If I got it right it's neither a language, nor a development tool or library so I'm not sure if it fit's in the purpose of this repository. On the other hand it clearly has something in common with software development. @Thomas-Boi what do you think? Open discussion for all users of devicon. Share your opinion! :)

@amacado amacado added discussion Community discussions about changes/features/.. feature:icon PR when a new icon is ready to be added to the collection labels Feb 21, 2021
@maltejur
Copy link
Contributor

That's a tough decision. I'm not sure if AArch64 fulfills our guidelines about which type of icons should be added to this project (see #353). If I got it right it's neither a language, nor a development tool or library so I'm not sure if it fit's in the purpose of this repository. On the other hand it clearly has something in common with software development. @Thomas-Boi what do you think? Open discussion for all users of devicon. Share your opinion! :)

Well even if it isn't a full fletched "programming language" in that sense, I still think if there even are icons for IDE's, this should definitely also have a place here.

@Panquesito7
Copy link
Member Author

Panquesito7 commented Feb 22, 2021

It's somewhat like a hardware-thing but a programming language too, but as @maltejur said

Well even if it isn't a full-fletched "programming language" in that sense, I still think if there even are icons for IDE's, this should definitely also have a place here.

I actually think this should be added here. As you can see in the AArch64 Assembly repository in The Algorithms, it is a programming language. However, Wikipedia states it's somewhat hardware-based (the image says it all). You can search through GitHub and you'll see this is a programming language. Not sure if it should be AArch64 or Assembly in this case (or AArch64 Assembly, which is both hardware and software). Offtopic: The use-case of this PR/icon is for a new website we're building, and we don't have icons for this programming language (see TheAlgorithms/website#7).

TL;DR: I think we should add this to the repository. As @maltejur said, there are icons for IDE's, so this icon should fit well here, too.

@Thomas-Boi
Copy link
Member

Hi @amacado,

As you can see in the AArch64 Assembly repository in The Algorithms, it is a programming language. However, Wikipedia states it's somewhat hardware-based (the image says it all). You can search through GitHub and you'll see this is a programming language

I think this is true. AArch64 does look like it's some form of an assembly language so I have no issue with accepting this PR (after checking the icons of course)

@Thomas-Boi Thomas-Boi added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Feb 22, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below:

![Peeked Icons (top left)](Imgur Images)

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this request. AArch64 does seem like a programming language and the files are created properly.

@amacado amacado merged commit 1edf59e into devicons:develop Feb 22, 2021
@Panquesito7 Panquesito7 deleted the icons/aarch64 branch February 22, 2021 19:31
@Panquesito7
Copy link
Member Author

Offtopic: @amacado I really love this project, it's pretty cool. I'd like to become a member of Devicons. I'll help with reviewing pull requests, adding new icons (in a pull request), etc.. Waiting on your response. Thank you! 🙂

@amacado
Copy link
Member

amacado commented Feb 23, 2021

@Panquesito7 you're welcome! I will contact you via mail so we can discuss some details 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger discussion Community discussions about changes/features/.. feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants