Skip to content

new icon: uwsgi (original, plain) #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2021
Merged

new icon: uwsgi (original, plain) #462

merged 3 commits into from
Jan 7, 2021

Conversation

EnisMulic
Copy link
Contributor

Taken from #170

@Thomas-Boi Thomas-Boi added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jan 6, 2021
@Thomas-Boi
Copy link
Member

Hello there,

Here is the result of the build process:

new_icons
screenshot_0
screenshot_1

I think the icons look pretty good. However, I would suggest removing the "original" version from the font attribute since it's very similar to the "plain" version. There's no need to add an alias for the "original" either, you can just remove it.

Thomas-Boi
Thomas-Boi requested changes Jan 6, 2021
View reviewed changes
@EnisMulic @Thomas-Boi
Update devicon.json
81c9810 
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
@Thomas-Boi
Copy link
Member

Everything looks good. Good job 👍

@Thomas-Boi Thomas-Boi merged commit ad45c83 into devicons:develop Jan 7, 2021
@EnisMulic EnisMulic deleted the feature/icon/uwsgi branch January 7, 2021 06:30
@amacado amacado mentioned this pull request Jan 19, 2021
Merged
@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Nov 5, 2023
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@Thomas-Boi
Merge pull request devicons#462 from EnisMulic/feature/icon/uwsgi
714e626 
new icon: uwsgi (original, plain)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Boi Thomas-Boi Thomas-Boi requested changes

Assignees
No one assigned
Labels
bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EnisMulic @Thomas-Boi @Snailedlt