Skip to content

Conversation

3flex
Copy link
Member

@3flex 3flex commented Sep 4, 2021

This will help reduce build times when changes are made to the precompiled script plugins used in the build. This is because a change in buildSrc causes the whole project to become out-of-date. Using an included build instead works around this problem.

Also see https://proandroiddev.com/stop-using-gradle-buildsrc-use-composite-builds-instead-3c38ac7a2ab3

This also helps if shared build logic needs to be used with other included builds, potentially the Gradle plugin or the detekt compiler plugin as discussed at #4052

@3flex 3flex added the housekeeping Marker for housekeeping tasks and refactorings label Sep 4, 2021
@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #4090 (76625cd) into main (5081b89) will not change coverage.
The diff coverage is n/a.

❗ Current head 76625cd differs from pull request most recent head 06db5b8. Consider uploading reports for the commit 06db5b8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4090   +/-   ##
=========================================
  Coverage     83.58%   83.58%           
  Complexity     3187     3187           
=========================================
  Files           459      459           
  Lines          9101     9101           
  Branches       1772     1772           
=========================================
  Hits           7607     7607           
  Misses          561      561           
  Partials        933      933           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5081b89...06db5b8. Read the comment docs.

@3flex 3flex force-pushed the build-logic2 branch 2 times, most recently from 92cc1ba to 76625cd Compare September 4, 2021 03:09
This will help reduce build times when changes are made to the precompiled
script plugins used in the build. This is because a change in buildSrc
causes the whole project to become out-of-date [0]. Using an included build
instead works around this problem.

[0] https://docs.gradle.org/7.2/userguide/organizing_gradle_projects.html#sec:build_sources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants