Add missing @octokit/request-error to package.json
#605
+225
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efb3d71 to
f2a6022
Compare
`src/main.ts` includes the import:
```javascript
import { RequestError } from '@octokit/request-error'
```
However, we weren't explicitly requiring this in `package.json`.
It was implicitly coming in via `@actions/github` import, but best
to be explicit about it.
Discovered via:
```shell
npm install -g npm-check
npm-check
```
Which reported the following error:
```
@octokit/request-error 😟 PKG ERR! Not in the package.json. Found in: /src/main.test.ts, /src/main.ts
```
Note: There is a _much_ newer version of `@octokit/request-error` available.
However, that threw some type errors due to breaking changes.
This `2.1.0` version was already pinned as a transitive dependency
in `package-lock.json`, so I went with that for now.
f2a6022 to
4b5bbe2
Compare
3486687 to
acbb0b0
Compare
jeffwidman
commented
Mar 21, 2025
Comment on lines
26
to
+27
| "@actions/github": "^5.1.1", | ||
| "@octokit/request-error": "^5.1.1", |
There was a problem hiding this comment.
These two probably will generally upgrade in lock-step since @actions/github is a hydrated wrapper around @octokit.
JamieMagee
approved these changes
Mar 21, 2025
landongrindheim
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/main.tsincludes the import:However, we weren't explicitly requiring this in
package.json. It was implicitly coming in via@actions/githubimport, but best to be explicit about it.Discovered via:
Which reported the following error:
Note: There is a newer
v6version of@octokit/request-erroravailable. However, it threw a type error due a breaking change. So for now I only bumped to thev5version, and we can fix the upgrade later. It's a step in the right direction to at least make this import explicit.