Delete duplicate CODEOWNERS #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a CODEOWNERS file at the root directory which wasn't working, and it's because GitHub prefers this location over the other. So we have to delete one or the other, I prefer the more visible one at the root, and we have a number of internal repos that also do that.
|
The files are not the same. Are the |
|
Yep I added that in #232. They are actually more invested in the CLI than we are at this point. |
Nishnha
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a CODEOWNERS file at the root directory which wasn't working, and it's because GitHub prefers this location over the other.
So we have to delete one or the other, I prefer the more visible one at the root, and we have a number of internal repos that also do that.