This repository was archived by the owner on Jun 16, 2025. It is now read-only.
Use json5 to parse tsconfig #806
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSConfig is a jsonc (JSON with comments) file, a proprietary format "used by a bunch of Microsoft products, most notably Typescript and VSCode"
https://www.typescriptlang.org/docs/handbook/declaration-files/dts-from-js.html#tsconfig
JSON.parse is not working when there are comments but we luckily have JSON5 available in the dependencies and it can do this just fine.