This repository was archived by the owner on Jun 16, 2025. It is now read-only.
Fix parsing Vue 3 files with Composition API and TypeScript #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f076c0 to
f707a83
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
+ Coverage 98.29% 98.30% +0.01%
==========================================
Files 50 50
Lines 1052 1053 +1
==========================================
+ Hits 1034 1035 +1
Misses 18 18
Continue to review full report at Codecov.
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vue 3 have new
<script setup>(Composition API) format for SFC filesSee https://vuejs.org/api/sfc-script-setup.html#script-setup
@vue/compiler-sfccan parse both, and we can find parsing results at:parsed.descriptor.scriptif code is written in traditional wayparsed.descriptor.scriptSetupif code is written using new<script setup>syntaxOne more problem is that
typescriptplugin wasn't included into vue.js parser (Vue 3 supports TypeScript by defining<script lang="ts">) and when depcheck encounters any TS in.vuefile, it just fails silently, skipping current file.PS: Currently, in
test/fake_modules/vue3/component.vuewe're checking only old vue2 format without TS, so I fixed this too.PSS: This PR solves #746