This repository was archived by the owner on Jun 16, 2025. It is now read-only.
feat: ignore url imports #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 50 50
Lines 1052 1052
=======================================
Hits 1034 1034
Misses 18 18
Continue to review full report at Codecov.
|
rumpl
approved these changes
Mar 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES Modules allows for absolute URL imports, but this currently does not work with depcheck - it will say that a file depends on the
https:/http:module, which is obviously incorrect.This PR ensures that imports that has an
http://orhttps://prefix (case insensitive) will be ignored.