Skip to content
This repository was archived by the owner on Jun 16, 2025. It is now read-only.

Conversation

Robbilie
Copy link
Contributor

@Robbilie Robbilie commented Aug 5, 2022

babel requires arrays, other parsers have this corrected, the typescript one doesnt and latest babel versions use destructuring which fails the whole parser rather than ignore the plugin

@codecov-commenter
Copy link

Codecov Report

Merging #745 (7bfedad) into main (f9eb0ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #745   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files          50       50           
  Lines        1052     1052           
=======================================
  Hits         1034     1034           
  Misses         18       18           
Impacted Files Coverage Δ
src/parser/typescript.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5132d5e...7bfedad. Read the comment docs.

@Robbilie
Copy link
Contributor Author

Robbilie commented Aug 5, 2022

previously

if (Array.isArray(plugin)) {
      return plugin[0] === name;
    } else {
      return plugin === name;
    }

more recent version

    if (typeof p === "string") {
      return expectedOptionsIsEmpty && p === expectedName;
    } else {
      const [pluginName, pluginOptions] = p;

which crashed with p not being enumerable…
if possible a fix for 0.8.x and 0.9.x would be nice…

@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 7, 2023
@am-a
Copy link

am-a commented Jan 30, 2023

Any chance this can be looked at again? As this effectively prevents upgrading to TS 4.9+

@stale stale bot removed the wontfix label Jan 30, 2023
@rumpl rumpl merged commit ad5ea25 into depcheck:main Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants