This repository was archived by the owner on Jun 16, 2025. It is now read-only.
If babel config is a function, call it to get config #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 98.64% 98.27% -0.36%
==========================================
Files 49 49
Lines 1023 1037 +14
==========================================
+ Hits 1009 1019 +10
- Misses 14 18 +4
Continue to review full report at Codecov.
|
|
Code looks good but it would be great to have a test for this |
|
I added a test case now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you define a
babel.config.jsyou can return a function, e.g.https://gist.github.com/gtzilla/a6ae9777a987df1ee1357df51bf9cd61
When parsing this config file, if it a returns a function the function has to be called and provided a stub implementation of that babel api.
See https://babeljs.io/docs/en/config-files#config-function-api
Fix for #723