Skip to content
This repository was archived by the owner on Jun 16, 2025. It is now read-only.

Conversation

pouya-eghbali
Copy link
Contributor

Adds Svelte support, closes #650

Had to upgrade node-sass to 6.0.0 as I use Node 16.x for development.
Added Svelte to devDependencies
Uses dynamic imports for Svelte to make it an optional dependency.

A Svelte test case is added.
The following command runs without issues:

npm run prettier-check && npm run lint && npm run test

@pouya-eghbali pouya-eghbali marked this pull request as ready for review June 8, 2021 14:25
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #652 (58cb163) into main (843f46d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   98.63%   98.63%   +0.01%     
==========================================
  Files          48       49       +1     
  Lines        1017     1021       +4     
==========================================
+ Hits         1003     1007       +4     
  Misses         14       14              
Impacted Files Coverage Δ
src/constants.js 100.00% <ø> (ø)
src/check.js 100.00% <100.00%> (ø)
src/parser/svelte.js 100.00% <100.00%> (ø)
src/utils/typescript.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdaa7bc...58cb163. Read the comment docs.

@rumpl
Copy link
Member

rumpl commented Jun 8, 2021

This is beautiful!

Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rumpl
Copy link
Member

rumpl commented Jun 8, 2021

Guess we should add node 16 to our matrix

@rumpl rumpl merged commit 2df335f into depcheck:main Jun 8, 2021
@pouya-eghbali pouya-eghbali deleted the svelte branch June 8, 2021 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte Support
2 participants