This repository was archived by the owner on Jun 16, 2025. It is now read-only.
Fix scss parsing for non-import '@' keywords #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #658 +/- ##
==========================================
+ Coverage 98.63% 98.64% +0.01%
==========================================
Files 49 49
Lines 1021 1023 +2
==========================================
+ Hits 1007 1009 +2
Misses 14 14
Continue to review full report at Codecov.
|
rumpl
reviewed
Aug 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looked like the scss parser was treating everything with
@as an import.I'm not super familiar with scss, but I consulted this doc for what can be an import: https://sass-lang.com/documentation/at-rules
It looks to me that only
@use,@import, and@forwardshould be treated as imports.Relates to #653
And #627 (comment)