Skip to content
This repository was archived by the owner on Jun 16, 2025. It is now read-only.

Conversation

Xyaren
Copy link
Contributor

@Xyaren Xyaren commented May 22, 2021

Fixes #570

Now iterates all override configs additionally to the main config.

@Xyaren
Copy link
Contributor Author

Xyaren commented May 22, 2021

I think I need help with that CI failure. I ran the tests locally and they were fine. What is happening?

@Xyaren
Copy link
Contributor Author

Xyaren commented May 22, 2021

~I tried to replicate the issue locally but I am not able to reproduce it. ~
Developing on a Windows machine is not really helpful in that way.
2 Completely unrelated test seem to fail and eslint/prettier is complaining about my line separators, that git changed while checking out the repo,

UPDATE: probably fixed. I used .flatMap which is not available in Node 10.x

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #641 (843f46d) into main (986ced3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
+ Coverage   98.62%   98.63%   +0.01%     
==========================================
  Files          48       48              
  Lines        1010     1017       +7     
==========================================
+ Hits          996     1003       +7     
  Misses         14       14              
Impacted Files Coverage Δ
src/special/eslint.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33505c...843f46d. Read the comment docs.

Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rumpl rumpl merged commit 3da0d6f into depcheck:main May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive: eslint overrides
2 participants