Update config reader to work in monorepo #631
Conversation
The config reader is aware of the context of the directory that the package.json file is in and will search only the same directory. This is useful in the context of monorepo where you want to run this with multiple different package.json file and their individula version of config file.
|
@rumpl , Would you be able to have a look at this? |
|
@AminFazlMondo 👋 sorry about that, I just started the CI and it seems red, could you take a look at it. Also, I'm not sure I 100% understand what issue this fixes, could you show me some examples please? Cheers |
|
Thanks for the response @rumpl , In regards to the context of the change, I have tried to use this useful package in our monorepos using lerna. The package structure is As you can see, each of the packages has its own config file for depcheck, and we want to be able to run the same command without needing to change the working directory (ie, Hopefully that clarifies the reason behind this change, please let me know if you need more details
|
Codecov Report
@@ Coverage Diff @@
## main #631 +/- ##
==========================================
+ Coverage 98.62% 98.62% +0.01%
==========================================
Files 48 48
Lines 1009 1010 +1
==========================================
+ Hits 995 996 +1
Misses 14 14
Continue to review full report at Codecov.
|
|
Thank you @AminFazlMondo, that was a crystal clear explanation! 👍 |
|
I just released version 1.4.1 that contains your changes, thanks a bunch |
The config reader is aware of the context of the directory that the package.json file is in and will search only the same directory.
This is useful in the context of monorepo where you want to run this with multiple different package.json file and their individula version of config file.