This repository was archived by the owner on Jun 16, 2025. It is now read-only.
fix: fixing broken gatsby parser #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #622 +/- ##
==========================================
+ Coverage 98.61% 98.62% +0.01%
==========================================
Files 48 48
Lines 1006 1009 +3
==========================================
+ Hits 992 995 +3
Misses 14 14
Continue to review full report at Codecov.
|
|
Cool! Could you add a test for this? |
|
@rumpl I think that test case should cover it! |
rumpl
approved these changes
Jan 26, 2021
|
Awesome, thank you @chris-hammond I'll whip up a new version tomorrow with this fix |
|
Thanks @rumpl ! Any update on releasing the new version? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Gatsby config parsing by updating the names of some internal object fields and adding support for TemplateLiterals which are used in several examples.