This repository was archived by the owner on Jun 16, 2025. It is now read-only.
Support react >= 17.0.0 that doesn't need to be imported #594
+111
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd8aa8e to
b42d3b0
Compare
Codecov Report
@@ Coverage Diff @@
## main #594 +/- ##
==========================================
+ Coverage 98.57% 98.58% +0.01%
==========================================
Files 47 48 +1
Lines 980 988 +8
==========================================
+ Hits 966 974 +8
Misses 14 14
Continue to review full report at Codecov.
|
We cheat a little bit here, if we see a react with version >=17 we immediately say that it is used because rules of how and when this is true are too complicated to implement with the system we have. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cheat a little bit here, if we see a react with version >=17 we
immediately say that it is used because rules of how and when this is
true are too complicated to implement with the system we have.
Fixes #591