This repository was archived by the owner on Jun 16, 2025. It is now read-only.
fix(sass-parser): ignore local import in scss #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support local imports ignore in scss files - dependencies with ':'
Separate SCSS parser inside the SASS parser according to file suffix
Codecov Report
@@ Coverage Diff @@
## main #581 +/- ##
==========================================
+ Coverage 98.48% 98.57% +0.08%
==========================================
Files 47 47
Lines 925 980 +55
==========================================
+ Hits 911 966 +55
Misses 14 14
Continue to review full report at Codecov.
|
rumpl
approved these changes
Nov 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue with depcheck in scss.
Apparently SCSS is not parsed the same way as SASS. When parsing SCSS, local imports (like importing _mixins.scss) is not overridden by the importer.
This is fixed by adding another SCSS parser.