Announce panel resize events to screen readers #19649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
commented
Dec 2, 2024
Comment on lines
+186
to
+187
| } width ${directionMessage}. Set to ${this.getResizePercentage()}%`, | ||
| }) |
There was a problem hiding this comment.
More accurately "Set to x% of available width" since available width is determined by app window.. which could change.. thus if you set it to 50% and then made the window wider it may now be 30%.. But... I don't think that "of available width" communicates that and just adds clutter to an already long message.
niik
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://github.com/github/accessibility-audits/issues/8565
Description
This PR announces the resizable resize events to screen reader users. It announces a resizable description, the resize type (increase/decrease), and the percentage of total width it is set to. This message is debounced.
Screenshots
CleanShot.2024-12-02.at.15.45.46.mp4
Release notes
Notes: [Improved] Resize events of resizable elements are announced by screen readers.