Move parsing of file names into presentation layer #19581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm attempting to remove as much responsibilities as possible from
gitandspawnin order to enable development of new, streaming, APIs for interacting with Git. In doing so I noticed this logic ingitwhich attempts to parse the error message and modify it to include the names of the large files that GitHub rejected. This seems like an ill fit for this logic so I've moved it to the presentation layer instead where we can present a nicer UI with a bulleted list. At the same time I aligned our message a little closer with what GitHub.com includes in their error messages, including a link to the online large file documentation.Screenshots
Release notes
Notes: