Check if the path being checked is the create a new repo is actually the suggested new path #19141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19137
Description
This PR updates our isGitHubRepository method to not incorrectly identify subfolders of a directory as being repositories and block the user from creating a repository out of subdirectory with the "This directory appears to be a Git repository".
Other thoughts:
path
+name
or 2) they really want submodules. This could be an opportunity to instead of showing an error show a "Did you know?" message about submodules and/or a warning..Screenshots
Below we see that
github/testing
is a repository so if I addingtesting
to the path. It is now checking ifgithub/testing/testing
is a repository which it is not.CleanShot.2024-08-21.at.11.44.13.mp4
Release notes
Notes: [Fixed] The "Create a New Repository" dialog allows creation of repositories of repository subfolders.