Announce "diff expanded" action #19128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref. https://github.com/github/accessibility-audits/issues/8588?reload=1?reload=1
Description
This PR just uses the existing aria live region in our diffs to announce when the user expands it. The biggest challenge here was to make this work with the existing live messages related to text search.
I added a private variable as a signal to tell our
AriaLiveContainerwhen it has to re-read the message even if the text is the same (using thetrackUserInputprop).Screenshots
CleanShot.2024-08-19.at.13.25.58.mp4
Release notes
Notes: [Improved] Use screen reader to announce when users expands the current diff