Squash dialog input labels #19100
Merged
Squash dialog input labels #19100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
commented
Aug 13, 2024
Comment on lines
+1398
to
+1412
| {this.props.showInputLabels === true && ( | ||
| <label htmlFor="commit-message-description">Description</label> | ||
| )} | ||
| <FocusContainer | ||
| className="description-focus-container" | ||
| onClick={this.onFocusContainerClick} | ||
| > | ||
| <AutocompletingTextArea | ||
| inputId="commit-message-description" | ||
| className={descriptionClassName} | ||
| screenReaderLabel="Commit description" | ||
| screenReaderLabel={ | ||
| this.props.showInputLabels !== true | ||
| ? 'Commit description' | ||
| : undefined | ||
| } |
There was a problem hiding this comment.
If you are wondering why I pulled the label out... I didn't want to :D
The FocusContainer there is a faux input border so that the text area and co author inputs look like one input. Thus, adding a label directly above the actual textarea input resulted in it being included inside the faux input border.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://github.com/github/accessibility-audits/issues/5637
Description
This PR adds input labels to the squash dialog so that the inputs are consistent with our other dialogs and therefore more accessible by providing visual labeling of the inputs. (Not relying on placeholders that are not visible on dialog open because the inputs are pre-populated).
Screenshots
Squash Dialog:
Changes List (Showing unchanged):
Release notes
Notes: [Improved] The squash dialog provides input labels.