Improve contrast of diff file warnings #19097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref. https://github.com/github/accessibility-audits/issues/8665
Description
This PR fixes the contrast ratio of the diff file warnings (like existence of hidden bidi characters or changes in EOL) to improve readability and accessibility.
More specifically, it changes the background color of the file warning from
#{$yellow-200}to#{$yellow-100}and the text color from#{$yellow-800}to#{darken($yellow-700, 10%)}(which is the color used by thefile-modifiedthat can, sometimes, be seen right next to it).Testing: one way of forcing this warning is this change:
Screenshots
Release notes
Notes: [Fixed] Increase contrast ratio of icon in diff file warnings