Skip to content

Adds erb-formatter support #4546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

Adds erb-formatter support #4546

merged 1 commit into from
Jul 24, 2023

Conversation

arashm
Copy link
Contributor

@arashm arashm commented Jul 3, 2023

Adds support for ERB::Formatter (https://github.com/nebulab/erb-formatter)

Tried to follow other MRs to create tests and relevant documentations.

@arashm arashm force-pushed the erb-formatter-fixer branch 4 times, most recently from 5ac630e to d345698 Compare July 3, 2023 15:56
@arashm
Copy link
Contributor Author

arashm commented Jul 3, 2023 •
edited
Loading

I honestly can't figure out why the linter is failing. It's seems to me that I have put the erb-formatter in the correct position in the ToC, and also used ale-eruby-erb-formatter header. If someone could point me to the issues, it would be awesome. Thanks.

@arashm arashm force-pushed the erb-formatter-fixer branch from d345698 to 6058108 Compare July 3, 2023 23:22
@arashm arashm force-pushed the erb-formatter-fixer branch from 6058108 to 90452fd Compare July 3, 2023 23:51
@arashm
Copy link
Contributor Author

arashm commented Jul 3, 2023

Fixed all issues now.

hsanson
hsanson approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@hsanson hsanson merged commit 93a4f70 into dense-analysis:master Jul 24, 2023
@arashm arashm mentioned this pull request Jul 24, 2023
Merged
mnikulin pushed a commit to mnikulin/ale that referenced this pull request Nov 12, 2023
@arashm @mnikulin
Add erb-formatter support (dense-analysis#4546)
ae85b42
cyyever pushed a commit to cyyever/ale that referenced this pull request Mar 24, 2025
@arashm @cyyever
Add erb-formatter support (dense-analysis#4546)
f3fab21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanson hsanson hsanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arashm @hsanson