Add chapter metadata #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… converting via ffmpeg
|
Thanks again! You've helped me a lot, and I really appreciate it. I'm merging this into beta and testing it now. |
Merged
denizsafak
added a commit
that referenced
this pull request
May 4, 2025
- Added new output format: `m4b`, enabling chapter metadata in audiobooks. Special thanks to @jborza for implementing this feature in PR #10. - Better approach for determining the correct configuration folder for Linux and MacOS, using platformdirs. (Fixes Docker issue #12) - Improvements in documentation and code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #9
Added a new output format 'm4b', which will include chapters info.
To test it, I used an epub with chapters.
As libsndfile doesn't support m4a/m4b format, we first generate to a wav format, then
use ffmpeg to convert, including the chapters info.
ffmpeg gets installed on the first conversion, using static_ffmpeg package,
however, I'm not very happy with the way it works, as it installed another ffmpeg
binary into my system instead of finding that I already have ffmpeg on the path.
When the conversion completes, we delete the .wav file, chapters.txt and report
back success, with conversion to the m4b format.
Another thing - if ffmpeg conversion fails, maybe we could just jump to
except Exception as e:statement in run(), and not catch the exception inexcept subprocess.CalledProcessError as e:, although we'd end up with two extra files - the .wav and chapters.txt.Cheers