Skip to content

feat: make setImmediate and clearImmediate as globals #29877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 25, 2025
Merged

feat: make setImmediate and clearImmediate as globals #29877

merged 5 commits into from
Jun 25, 2025

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jun 24, 2025 •
edited
Loading

Follow up to #29323 and #29416.

This effort is to reduce a number of different globals available to user
code and npm dependencies. Also improves performance when these globals are used.
This brings the number of "managed globals" down to 6.

Towards #29703

@bartlomieju bartlomieju changed the title feat: make 'setImmediate and clearImmediate` as globals feat: make setImmediate and clearImmediate as globals Jun 24, 2025
@bartlomieju bartlomieju mentioned this pull request Jun 16, 2025
Open
12 tasks
nathanwhit
nathanwhit approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit d4b0245 into denoland:main Jun 25, 2025
18 checks passed
@bartlomieju bartlomieju deleted the immediate_globals branch June 25, 2025 13:21
@bartlomieju bartlomieju mentioned this pull request Jun 25, 2025
Merged
bartlomieju added a commit that referenced this pull request Jun 26, 2025
@bartlomieju
feat: deprecate --unstable-node-globals flag (#29887)
e8d9d59 
`--unstable-node-globals` flag is no longer needed after following
PRs had landed:
- #29877
- #29734
- #29416

This commit hides this flag from the `--help=unstable` output,
but still keep the flag to not break previously working invocations.
zloirock added a commit to zloirock/core-js that referenced this pull request Jul 1, 2025
@zloirock
mark setImmediate and clearImmediate as available from Deno 2.4
f783679 
denoland/deno#29877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@ry ry Awaiting requested review from ry

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @nathanwhit