Skip to content

Conversation

nayeemrmn
Copy link
Contributor

Fixes #28662.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@nayeemrmn nayeemrmn merged commit 2508286 into denoland:main Apr 30, 2025
18 checks passed
@nayeemrmn nayeemrmn deleted the lsp-auto-import-import-map-prefer-relative branch April 30, 2025 14:12
@bira37
Copy link

bira37 commented Jun 3, 2025

Why not provide an option to prefer relative imports instead of enforcing them? At our company, we standardize all projects to use absolute imports via the import map, and now that the LSP defaults to relative imports, we’re having to manually change many import lines back to absolute ones — which is both tedious and error-prone.

This behavior changed from how it previously worked, and it’s now affecting our workflow significantly. I don’t believe it was a fair change without at least offering configurability. I opened an issue about this #29464.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-imports don't respect typescript.preferences.importModuleSpecifier
3 participants