Skip to content

feat(check): detect tsconfig.json at workspace root #29092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 29, 2025
Merged

feat(check): detect tsconfig.json at workspace root #29092

merged 5 commits into from
Apr 29, 2025

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Apr 29, 2025 •
edited by dsherret
Loading

This PR adds detection of tsconfig.json at the root of a workspace when there exists either a deno.json or package.json. If a project already has deno.json with a compilerOptions value the tsconfig.json is ignored.

The main part of this change was implemented in:

closes #27095
ref #28455

@kt3k kt3k requested review from dsherret and bartlomieju April 29, 2025 13:15
@bartlomieju bartlomieju added this to the 2.3.0 milestone Apr 29, 2025
@dsherret dsherret mentioned this pull request Apr 29, 2025
Merged
dsherret added a commit to denoland/deno_config that referenced this pull request Apr 29, 2025
@dsherret
fix(tsconfig): do not warn for not found errors (#167)
67d4cd7 
For denoland/deno#29092
@dsherret dsherret changed the title feat(check): detect tsconfig.json feat(check): detect tsconfig.json at workspace root Apr 29, 2025
dsherret
dsherret approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsherret dsherret enabled auto-merge (squash) April 29, 2025 19:54
@dsherret dsherret merged commit 58b679a into denoland:main Apr 29, 2025
18 checks passed
@kt3k kt3k deleted the detect-tsconfig-json branch April 30, 2025 00:58
@kt3k kt3k mentioned this pull request May 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Support tsconfig.json
3 participants
@kt3k @dsherret @bartlomieju