feat: use new feature checker #29091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91c7c1a to
73e3230
Compare
b5b2b15 to
75e4bd5
Compare
75e4bd5 to
3e84889
Compare
bartlomieju
approved these changes
Apr 29, 2025
|
|
||
| /// Helper for checking unstable features. Used for sync ops. | ||
| pub fn check_unstable(state: &OpState, feature: &str, api_name: &str) { | ||
| state.feature_checker.check_or_exit(feature, api_name); | ||
| state | ||
| .borrow::<Arc<FeatureChecker>>() |
There was a problem hiding this comment.
I'm wondering if we should bury Arc inside FeatureChecker. Seems like an implementation detail. Feel free to do it in a follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to be able to set the feature checker after creating the runtime to support lazy init