Skip to content

fix: make --allow-env stronger that --deny-env #29079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2025
Merged

fix: make --allow-env stronger that --deny-env #29079

merged 3 commits into from
Apr 28, 2025

Conversation

bartlomieju
Copy link
Member

No description provided.

@bartlomieju bartlomieju requested a review from dsherret April 28, 2025 16:00
@dsherret dsherret changed the title fix: Make --allow-env stronger that --deny-env fix: make --allow-env stronger that --deny-env Apr 28, 2025
dsherret
dsherret approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit f2ae7a1 into denoland:main Apr 28, 2025
18 checks passed
@bartlomieju bartlomieju deleted the fix_env_check branch April 28, 2025 17:28
dsherret pushed a commit that referenced this pull request May 13, 2025
@bartlomieju @dsherret
fix: make --allow-env stronger that --deny-env (#29079)
946ccda
dsherret pushed a commit that referenced this pull request May 13, 2025
@bartlomieju @dsherret
fix: make --allow-env stronger that --deny-env (#29079)
2959e08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret