Skip to content

fix: move otel logic into otel #29073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix: move otel logic into otel #29073

merged 1 commit into from
Apr 28, 2025

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Apr 28, 2025

cleanup 229228a

@devsnek devsnek requested a review from dsherret April 28, 2025 12:21
bartlomieju
bartlomieju approved these changes Apr 28, 2025
View reviewed changes
cli/main.rs
otel_config.clone(),
)?;
}
deno_telemetry::init(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be renamed to maybe_init?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah i think its sort of an implementation detail

@devsnek devsnek merged commit f360d61 into main Apr 28, 2025
18 checks passed
@devsnek devsnek deleted the x/cleanup-fix branch April 28, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devsnek @bartlomieju