Skip to content

fix(ext/node): use primordials in ext/node/polyfills/internal/hide_stack_frames.ts #29067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix(ext/node): use primordials in ext/node/polyfills/internal/hide_stack_frames.ts #29067

merged 1 commit into from
Apr 28, 2025

Conversation

jbronder
Copy link
Contributor

Towards #24236. This PR replaces Object.defineProperty with its primordial ObjectDefineProperty.

@jbronder
fix(ext/node): use primordials in
5821f5c 
`ext/node/polyfills/internal/hide_stack_frames.ts`
@CLAassistant
Copy link

CLAassistant commented Apr 27, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@iuioiua iuioiua mentioned this pull request Apr 28, 2025
Open
92 tasks
kt3k
kt3k approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 98cf8f4 into denoland:main Apr 28, 2025
18 checks passed
@jbronder jbronder deleted the hide_stack_frames_primordial branch April 28, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbronder @CLAassistant @kt3k