Skip to content

fix(otel): only start deno_telemetry thread when needed #29065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2025
Merged

fix(otel): only start deno_telemetry thread when needed #29065

merged 1 commit into from
Apr 27, 2025

Conversation

lrowe
Copy link
Contributor

@lrowe lrowe commented Apr 26, 2025 •
edited by dsherret
Loading

Closes #29064

@lrowe lrowe force-pushed the otel-only-when-needed branch from 9b45d5c to 0cb485d Compare April 26, 2025 21:45
@lrowe lrowe force-pushed the otel-only-when-needed branch from 0cb485d to 40e2a7a Compare April 26, 2025 21:48
@dsherret dsherret changed the title fix(otel): Only start deno_telemetry thread when needed. Closes #29064. fix(otel): only start deno_telemetry thread when needed Apr 27, 2025
dsherret
dsherret approved these changes Apr 27, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

This might also fix #29036

@dsherret dsherret merged commit 229228a into denoland:main Apr 27, 2025
18 checks passed
@dsherret dsherret mentioned this pull request Apr 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telemetry thread should not be started when not configured
2 participants
@lrowe @dsherret