fix(ext/node): implement DatabaseSync#loadExtension #29050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Apr 28, 2025
| )); | ||
|
|
||
| if allow_extension { | ||
| perms.check_ffi_all()?; |
There was a problem hiding this comment.
Why is there no API name here in case perm check fails?
There was a problem hiding this comment.
Doesnt seem to be the part of the the FFI perms API.
| fn() { | ||
| // skip the test if the extension is not found | ||
| try { | ||
| Deno.statSync(extensionPath); |
There was a problem hiding this comment.
Won't this cause the test to always succeed if something goes wrong?
There was a problem hiding this comment.
This is like tests/ffi so not ran directly using deno test. With cargo t -p sqlite_extension_test the extension is always built.
bartlomieju
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires full
--allow-ffiFixes #29030