perf(lockfile): slightly terser lockfile formatting, remove old lockfile code #28992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the lockfile-related modules to adapt to the latest changes in deno_lockfile, deno_npm, and eszip. It removes the legacy lockfile v4 snapshot loading, adopts a terser lockfile formatting for the os and cpu fields, and updates dependency versions accordingly.
- Updated lockfile initialization to use Lockfile::new with an async npm package info provider.
- Removed legacy error handling related to lockfile snapshot integrity checks.
- Upgraded dependency versions and added the async-trait dependency for test suites.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/jsr_tests.rs | Updated lockfile initialization and added async test npm provider. |
| tests/integration/check_tests.rs | Applied similar lockfile initialization update with async provider. |
| tests/Cargo.toml | Added async-trait to dev-dependencies. |
| cli/npm/mod.rs | Removed unused types and updated default tarball URL usage. |
| cli/npm/managed.rs | Removed legacy error method and updated snapshot API usage. |
| cli/npm/installer/resolution.rs | Updated default tarball URL call to use the new API signature. |
| cli/main.rs | Simplified error handling by removing custom integrity check logic. |
| cli/args/lockfile.rs | Revised lockfile construction to match the updated API. |
| Cargo.toml | Upgraded deno_lockfile, deno_npm, and eszip to the newer versions. |
Comments suppressed due to low confidence (1)
cli/main.rs:425
- The removal of differentiated error code handling for integrity check errors now results in all errors exiting with code 1. Please verify that this change is intentional, ensuring that specific integrity check failures are not inadvertently masked.
exit_with_message(&error_string, 1);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically just update deno_lockfile, deno_npm, and eszip, and then adapt to those changes. The main changes were the removal of the lockfile v4 resolution snapshot loading, and a terser formatting for the
osandcpufields in the lockfile.