fix(npm): only print deprecation warnings on first install #28990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a regression from the packument refactor by ensuring deprecation warnings are printed only on the first install. Key changes include:
- Adding a new test case for deprecation warnings in the npm specs.
- Removing the helper function handle_package_scripts_bin_deprecated and inlining its behavior.
- Updating conditionals to control when deprecation warnings are recorded.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/specs/npm/deprecation_warnings_no_repeat/main.ts | Adds a test to verify that deprecation warnings are not repeated on subsequent installs |
| cli/npm/installer/local.rs | Inlines handling of package scripts, bin setups, and deprecation warnings, with modified conditional logic |
Files not reviewed (1)
- tests/specs/npm/deprecation_warnings_no_repeat/test.jsonc: Language not supported
Comments suppressed due to low confidence (1)
cli/npm/installer/local.rs:451
- Removing the check for package.is_deprecated in this condition might cause deprecated packages without bin or scripts to be skipped from deprecation warnings. Confirm that this is the intended behavior for first install deprecation handling.
if package.has_bin || package.has_scripts {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28933.
This was a regression from the packument refactor.